Fixed DynamoDbEnhancedClient DefaultDynamoDbAsyncTable::createTable()… #5847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roamariei
force-pushed
the
bugfix/async-client-fails-to-generate-secondary-indexes-from-annotations-pojo-class
branch
from
726a764 to
a802297
Compare
shetsa-amzn
reviewed
Apr 7, 2025
|
@shetsa-amzn |
roamariei
force-pushed
the
bugfix/async-client-fails-to-generate-secondary-indexes-from-annotations-pojo-class
branch
3 times, most recently
from
9b3a69f to
c3e941f
Compare
roamariei
force-pushed
the
bugfix/async-client-fails-to-generate-secondary-indexes-from-annotations-pojo-class
branch
2 times, most recently
from
6c8ec46 to
5357dcd
Compare
zoewangg
requested changes
May 23, 2025
...odb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/IndexUtils.java
Outdated
Show resolved
Hide resolved
...java/software/amazon/awssdk/enhanced/dynamodb/internal/client/DefaultDynamoDbAsyncTable.java
Outdated
Show resolved
Hide resolved
roamariei
force-pushed
the
bugfix/async-client-fails-to-generate-secondary-indexes-from-annotations-pojo-class
branch
3 times, most recently
from
cb51803 to
b636dca
Compare
|
Hi @zoewangg, |
roamariei
force-pushed
the
bugfix/async-client-fails-to-generate-secondary-indexes-from-annotations-pojo-class
branch
from
b636dca to
9a432cd
Compare
zoewangg
reviewed
May 23, 2025
...b-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/TableIndices.java
Outdated
Show resolved
Hide resolved
...b-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/internal/TableIndices.java
Outdated
Show resolved
Hide resolved
roamariei
force-pushed
the
bugfix/async-client-fails-to-generate-secondary-indexes-from-annotations-pojo-class
branch
from
ed2be55 to
52d6e25
Compare
|
LGTM, waiting for secondary reviewer @dagnir to review. @roamariei jfyi, let's not squash commits going forward since it'd make it hard to review changes between revision. :) Triggering builds. |
|
…dices that are defined on annotations of the POJO class, similar to DefaultDynamoDbTable::createTable()
roamariei
force-pushed
the
bugfix/async-client-fails-to-generate-secondary-indexes-from-annotations-pojo-class
branch
from
52d6e25 to
e51d00b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed DynamoDbEnhancedClient DefaultDynamoDbAsyncTable::createTable() to create secondary indices that are defined on annotations of the POJO class, similar to DefaultDynamoDbTable::createTable().
Description
Current behavior: DynamoDbEnhancedAsyncClient#createTable() fails to generate secondary indexes that are defined on annotations of the POJO class.
Expected behavior: DynamoDbEnhancedAsyncClient#createTable() should generate secondary indexes that are defined on annotations of the POJO class, similar to DefaultDynamoDbTable::createTable().
Motivation and Context
#5400
Modifications
Followed the same approach as the synchronous flow in DefaultDynamoDbTable::createTable(). Refactored existing code to enable reuse across both classes.
Testing
The changes have already been tested in the synchronous flow, and additional unit tests have been added for the newly created utility class.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License